Correct html rendering when using profdata format #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cutz
changed the title
|
Just want to say that sourcing Slather from venmo/slather:master produced a code coverage report that is different from Xcode. Thanks to cutz:fix-122-profdata-html-output branch for fixing it. Hope this gets merged if all the necessary checks are done. |
|
@cutz Thanks for the contribution! |
neonichu
added a commit
that referenced
this pull request
Feb 3, 2016
Correct html rendering when using profdata format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides a fix for #122 and corrects a couple of the test fixtures that were masking the issue when running the tests.